Use standard key behavior in array_column() #5487
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ramsey as the original author of this functionality. The RFC https://wiki.php.net/rfc/array_column does not specify a specific behavior. |
|
I don't recall why I implemented a separate treatment for keys, but it makes sense to me to use the standard API instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that array_column() implements its own bespoke treatment of array keys, that does not match how PHP generally handles array keys. This PR changes it to use a standard API instead.
Of course, there is a backwards compatibilty break here, e.g. people could be relying on objects getting cast to string instead of throwing.